Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changelog for 0.28.0 #2303

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

SteveLauC
Copy link
Member

What does this PR do

Prepare for a new release 0.28.0, and edit the changelog for it.

If a new release is allowed, then I will:

  1. Update the version number in Cargo.toml
  2. Run cargo release
  3. Push the above changes directly to the master branch

Since this is a one-way trip, hi @asomers, is there anything you want to do before 0.28.0?

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@asomers
Copy link
Member

asomers commented Jan 31, 2024

Is there anything left that you'd like me to do on #2269 first?

@SteveLauC
Copy link
Member Author

SteveLauC commented Jan 31, 2024

Is there anything left that you'd like me to do on #2269 first?

There are 2 requested changes in #2269, would you like to resolve them?

CHANGELOG.md Outdated
- `mmap`, `mmap_anonymous`, `munmap`, `mremap`, `madvise`, `msync`, `mprotect`,
`munlock` and `mlock` updated to use `NonNull`.
([#2000](https://github.com/nix-rust/nix/pull/2000))
- Simplified the function signatures of `recvmmsg` and `sendmmsg`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to remove this change before releasing a new version, since this would be a regression of safety (#2120 fixed a safety bug but embarrassingly also introduced a new one, as explained in #2162, revert in #2227).

I'll revisit #2227 later this day and probably make some slight changes to better match the previous version regarding some elided lifetimes (my version should be equivalent, but I should have opened a separate PR to remove the additional lifetimes that became redundant in recent compiler versions instead of doing both things in one PR).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to remove this change before releasing a new version

Will do it when updating this PR:)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SteveLauC SteveLauC merged commit 595c6eb into nix-rust:master Feb 24, 2024
5 of 12 checks passed
@SteveLauC SteveLauC deleted the changelog_0.28.0 branch February 24, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants