update performance test to produce same result for both tests #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes: - howLong now uses MonoTime to calculate the diff. This is simpler and has less overhead than cpuTime, at least. - `Iterator` gains a yielded marker to distinguish between regular jumps and `jield`, with a convienence `next()` proc to advance the iteration. - Changed closure iterator test to one where the parameters are saved. This puts it inline with what cps does. - Tweaked the termination condition so that it is checked after the iteration is run, this is because an iterator "finished" state changes after it is run, so using the numbers without checking if it's produced by the iterator or its the default due to the iterator ending is error prone. Currently CPS is 3.5x slower than Nim, tested on an AMD Ryzen 5 3600.
disruptek
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
howLongnow usesMonoTimeto calculate the diff. This is simpler andhas less overhead than
cpuTime, at least.Iteratorgains a yielded marker to distinguish between regular jumpsand
jield, with a convienencenext()proc to advance the iteration.This puts it inline with what cps does.
iteration is run, this is because an iterator "finished" state changes
after it is run, so using the numbers without checking if it's
produced by the iterator or its the default due to the iterator ending
is error prone.
Currently CPS is 3.5x slower than Nim, tested on an AMD Ryzen 5 3600.
Ref #243