Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process stalling for 4 mins after test run in Node v20+. #3976

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

garg3133
Copy link
Member

This was happening because the https library now creates connections to be keep-alive by default (related PR), which stays open until the response is read completely (nodejs/node#50188 (comment)).

So, this PR fixes the issue by reading the response data.

Another fix was to set the Connection header to 'close' (nodejs/node#50188 (comment)), but I think the fix in this PR is the correct one.

Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@beatfactor beatfactor merged commit fc10ac1 into nightwatchjs:main Dec 12, 2023
17 checks passed
@garg3133 garg3133 deleted the node20-fix branch December 13, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants