Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visibility of Boluswizard and Insulin button in AAPSClient #3374

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

olorinmaia
Copy link
Contributor

@olorinmaia olorinmaia commented Jun 23, 2024

You can't bolus via pump from AAPSClient, thus it makes no sense to hide Insulin and Boluswizard button in AAPSClient when pump is disconnected from AAPS. This change will make visibility to these buttons to be similar to that of Carbs button.

We disconnect pump in AAPS when our son goes swimming, and it would be useful to check Bolus wizard for missing carbs for example in AAPSClient.

AAPS (Pump connected) AAPSClient (Pump connected)
image image
AAPS (Pump disconnected) AAPSClient (Pump disconnected)
image image

@Philoul
Copy link
Contributor

Philoul commented Jul 20, 2024

Not sure to understand your proposal (why you keep Insulin button in AAPSClient version 🤔).
Keep also in mind that you also have a PumpControl version of AAPS.

@olorinmaia
Copy link
Contributor Author

olorinmaia commented Jul 20, 2024

AAPSClient is for follower as you know. It is not possible to administer insulin via pump in any scenario. Thus there is no reason to hide the buttons.

When we disconnect pod it is useful some times to register insulin given by pen.

@Philoul
Copy link
Contributor

Philoul commented Jul 21, 2024

I can be wrong (never used AAPSClient myself), but I thought it was possible to send a bolus from AAPSClient to AAPS followed remotly...

@olorinmaia
Copy link
Contributor Author

You can add a bolus from AAPSClient that count towards iob, but will not be delivered by pump. This warning is always visible and can't be turned off.😉

Screenshot_20240721_220637_AAPSClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants