Add comments to on_process_message_received (software-mansion#204)

nickdichev-firework · Oct 11, 2023 · c20e3a0 · c20e3a0
1 parent 476345e
commit c20e3a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/compositor_chromium/src/render_process_handler.rs b/compositor_chromium/src/render_process_handler.rs
@@ -11,6 +11,8 @@ pub trait RenderProcessHandler {
     /// Called when a new [`V8Context`] for a [`Frame`] was created
     fn on_context_created(&mut self, _browser: &Browser, _frame: &Frame, _context: &V8Context) {}
 
+    /// Called when new process message is received.
+    /// Return `true` if message was handled, `false` otherwise
     fn on_process_message_received(
         &mut self,
         _browser: &Browser,

diff --git a/src/bin/process_helper/handler.rs b/src/bin/process_helper/handler.rs
@@ -35,7 +35,6 @@ impl cef::RenderProcessHandler for RenderProcessHandler {
         _source_process: cef::ProcessId,
         message: &cef::ProcessMessage,
     ) -> bool {
-        const IS_HANDLED: bool = true;
         let result = match message.name().as_str() {
             EMBED_SOURCE_FRAMES_MESSAGE => self.embed_sources(message, frame),
             UNEMBED_SOURCE_FRAMES_MESSAGE => self.unembed_source(message, frame),
@@ -44,9 +43,12 @@ impl cef::RenderProcessHandler for RenderProcessHandler {
 
         if let Err(err) = result {
             error!("Error occurred while processing IPC message: {err}");
+            // Message was not handled
+            return false;
         }
 
-        IS_HANDLED
+        // Message was handled
+        true
     }
 }