Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔥 write aws-service test code & remove duplicated service #320

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

okinawaa
Copy link
Contributor

Service name "Cognito" was duplicated in aws-service.json so I remove one and there isn't test code which verify aws-service function so I wrote it

BREAKING CHANGE: 🧨 no

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Service name "Cognito" was duplicated in aws-service.json so I remove
one and there isn't test code which verify aws-service function so I
wrote it

BREAKING CHANGE: 🧨 no
@stackblitz
Copy link

stackblitz bot commented Nov 16, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@okinawaa
Copy link
Contributor Author

float.spec.ts
Tests sometimes fail. It's extremely dangerous to fail in some cases, not always, so I'll fix it!

@okinawaa
Copy link
Contributor Author

image

Typically, a decimal point occurs, but that's the result we want, but it can also be an integer.

@okinawaa
Copy link
Contributor Author

If PR #321 is merged, this CI failure will be resolved.

@NetanelBasal NetanelBasal merged commit c868691 into ngneat:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants