Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: nightwatch (again) #639

Merged
merged 4 commits into from
Jul 18, 2017
Merged

ENH: nightwatch (again) #639

merged 4 commits into from
Jul 18, 2017

Conversation

hainm
Copy link
Collaborator

@hainm hainm commented Jul 18, 2017

Damn, finally I can make notebook test with chromedriver works again.
Very tricky (need to use correct chromedriver version (in this case, v2.30)).

Example

$ nightwatch 
Starting selenium server... started - PID:  17011

[Render Image] Test Suite
=============================

Running:  nglview/tests/notebooks/api/render_image.ipynb
url http://localhost:8889/notebooks/nglview/tests/notebooks/api/render_image.ipynb
 ✔ Passed [ok]: Check that python has no error
 ✔ Passed [ok]: Check that python has no error
 ✔ Passed [ok]: Check that python has no error
 ✔ Passed [ok]: Check that python has no error
 ✔ Passed [ok]: Check that python has no error
 ✔ Passed [ok]: Check that python has no error

@hainm hainm merged commit a3b5959 into nglviewer:master Jul 18, 2017
@hainm hainm deleted the nightwatch branch July 18, 2017 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant