Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): improved logging / renames / new exports #6085

Merged
merged 36 commits into from
Dec 22, 2022
Merged

feat(core): improved logging / renames / new exports #6085

merged 36 commits into from
Dec 22, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Dec 16, 2022 •
edited
Loading

  • Cleans up logging. Logs are now color-coded, added more debug logs, and errors can include some simple metadata (like provider id) to know which provider caused an issue.
  • All errors are exposed via @auth/core/errors. Each error has a URL like: https://errors.authjs.dev#errorcode in the terminal, which points to the documentation explaining the problem in detail, suggesting a fix.
  • Added a bunch of documentation that autogenerates the pages under https://authjs.dev/reference/core/modules/main
  • Renames AuthHandler to Auth and AuthOptions to AuthConfig
  • Throwing an error in signIn callback will now be caught as a general error and will redirect to /error?error=Configuration. If the callback returns false, it will redirect to /error?error=AccessDenied.

@vercel
Copy link

vercel bot commented Dec 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 22, 2022 at 2:34AM (UTC)
next-auth-docs 🔄 Building (Inspect) Dec 22, 2022 at 2:34AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth ⬜️ Ignored (Inspect) Dec 22, 2022 at 2:34AM (UTC)

@balazsorban44 balazsorban44 changed the title feat(core): overhauled logging feat(core): overhauled logging/renames Dec 16, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 16, 2022
View reviewed changes
packages/core/src/lib/pages/signin.tsx Fixed Show fixed Hide fixed
packages/core/src/lib/pages/signin.tsx Fixed Show fixed Hide fixed
packages/core/src/lib/pages/signin.tsx Fixed Show fixed Hide fixed
packages/core/src/lib/pages/signin.tsx Fixed Show fixed Hide fixed
packages/core/src/lib/pages/signin.tsx Fixed Show fixed Hide fixed
@balazsorban44 balazsorban44 marked this pull request as ready for review December 22, 2022 02:29
@balazsorban44 balazsorban44 changed the title feat(core): overhauled logging/renames feat(core): overhauled logging/renames/new exports Dec 22, 2022
@balazsorban44 balazsorban44 changed the title feat(core): overhauled logging/renames/new exports feat(core): improved logging / renames / new exports Dec 22, 2022
@balazsorban44 balazsorban44 merged commit 6c45abf into main Dec 22, 2022
@balazsorban44 balazsorban44 deleted the refactor/cleanup branch December 22, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

@ThangHuuVu ThangHuuVu Awaiting requested review from ThangHuuVu ThangHuuVu is a code owner

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@balazsorban44