Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Py37 #331

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Deprecate Py37 #331

merged 1 commit into from
Jun 8, 2023

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Jun 8, 2023

Python 3.7 reaches it's EOL in ~2 weeks, this PR deprecates it's support

https://endoflife.date/python

@dsikka
Copy link
Contributor

dsikka commented Jun 8, 2023

Question @rahul-tuli seems like we skipped the extensive-python-tests check - if we're changing Python version support, just wondering why this test was skipped?

@rahul-tuli
Copy link
Member Author

Question @rahul-tuli seems like we skipped the extensive-python-tests check - if we're changing Python version support, just wondering why this test was skipped?

Hi, great question, it's due to this line:

(echo $GITHUB_REF | grep -E "refs/heads/[release/|main]")
which disables extensive tests when the branch is not main or release

Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahul-tuli rahul-tuli merged commit f1c4b5e into main Jun 8, 2023
@rahul-tuli rahul-tuli deleted the deprecate-py37 branch June 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants