Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire flaky in favour of pytest-rerunfailures #1628

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Mar 5, 2024

Remove the dependency on flake (which is not actively maintained) in favour of pytest plugin. Also, allow for the newest pytest version

@dbogunowicz dbogunowicz changed the title initial commit Retire 'flaky in favour of pytest-rerunfailures` Mar 5, 2024
@dbogunowicz dbogunowicz changed the title Retire 'flaky in favour of pytest-rerunfailures` Retire flaky in favour of pytest-rerunfailures Mar 5, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mgoin mgoin merged commit 1ae58fb into main Mar 5, 2024
13 checks passed
@mgoin mgoin deleted the feature/damian/remove_flaky branch March 5, 2024 14:00
dhuangnm pushed a commit that referenced this pull request Mar 15, 2024
dhuangnm added a commit that referenced this pull request Mar 18, 2024
* [TextGeneration] Fix llama tokenizer (#1635)

* add llama tokenizer fix

* fix generated string

* only run for streaming

* add TODO

---------

Co-authored-by: Dipika Sikka <[email protected]>

* Retire `flaky` in favour of `pytest-rerunfailures` (#1628)

* pick up another fix and bump up version to 1.7.1

---------

Co-authored-by: Dipika Sikka <[email protected]>
Co-authored-by: Dipika Sikka <[email protected]>
Co-authored-by: dbogunowicz <[email protected]>
Co-authored-by: dhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants