docs(events): add events listener options #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
micalevisk
reviewed
Oct 18, 2023
content/techniques/events.md
Outdated
| @@ -94,6 +117,9 @@ handleOrderCreatedEvent(payload: OrderCreatedEvent) { | |||
| } | |||
| ``` | |||
|
|
|||
| > info **Hint** read more about ([listener options object](https://github.com/EventEmitter2/EventEmitter2#emitteronevent-listener-options-objectboolean)). | |||
There was a problem hiding this comment.
Suggested change
| > info **Hint** read more about ([listener options object](https://github.com/EventEmitter2/EventEmitter2#emitteronevent-listener-options-objectboolean)). | |
| > info **Hint** Read more about the [`OnOptions` options object from `eventemitter2`](https://github.com/EventEmitter2/EventEmitter2#emitteronevent-listener-options-objectboolean). |
what about this? I'd like to clarify from where that OnOptions came
There was a problem hiding this comment.
also, can we move this HINT to right below L111?
There was a problem hiding this comment.
i think that it is better.
There was a problem hiding this comment.
ok, move to below L111
Co-authored-by: Micael Levi L. Cavalcante <[email protected]>
micalevisk
approved these changes
Oct 18, 2023
koreanddinghwan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
event listener options object updated at feat: add suppress errors option
i think need more information to users who use events.
Does this PR introduce a breaking change?
Other information