Skip to content
This repository has been archived by the owner on Aug 13, 2021. It is now read-only.

[305] update GRID lookup logic #306

Merged
merged 2 commits into from
Aug 13, 2020
Merged

[305] update GRID lookup logic #306

merged 2 commits into from
Aug 13, 2020

Conversation

jaklinger
Copy link
Contributor

Closes #305

@jaklinger jaklinger added the bug Something isn't working label Aug 13, 2020
@jaklinger jaklinger requested a review from bishax August 13, 2020 09:28
@jaklinger jaklinger self-assigned this Aug 13, 2020
bishax
bishax reviewed Aug 13, 2020
View reviewed changes
Copy link
Contributor

@bishax bishax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not run any code but other than the 2 comments then looks good

nesta/packages/grid/grid.py Outdated Show resolved Hide resolved
nesta/packages/grid/grid.py Show resolved Hide resolved
@jaklinger jaklinger merged commit d85dede into dev Aug 13, 2020
@jaklinger jaklinger deleted the 305_grid branch August 13, 2020 13:29
jaklinger added a commit that referenced this pull request Sep 28, 2020
@jaklinger
[305] update GRID lookup logic (#306)
667370e 
* update lookup logic

* Updated comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bishax bishax bishax left review comments

Assignees

@jaklinger jaklinger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DAPS] GRID alias lookup was unaware of aliases in the main table
2 participants
@jaklinger @bishax