Fix some typing problems #1940
Merged
Fix some typing problems #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
SauravMaheshkar
added
quality of life
python
jkulhanek
force-pushed
the
jkulhanek/fix-typing-problems
branch
from
bfa283f
to
8e20087
Compare
jkulhanek
force-pushed
the
jkulhanek/fix-typing-problems
branch
from
8e20087
to
77dda66
Compare
|
@brentyi can you take a look? |
jkulhanek
commented
May 17, 2023
brentyi
approved these changes
May 18, 2023
|
FYI I'm going to try and get the rest of the type errors resolve today, and (hopefully) get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typing issues in models, model_components, fields. Now pyright, vscode (pylance) do not report any errors for these subpackages.