Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): getDocument return type. #5132

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

weirongxu
Copy link
Contributor

No description provided.

@weirongxu
Copy link
Contributor Author

Do we need to keep this undefined result or modify unit test to migrate to null?

@weirongxu
Copy link
Contributor Author

weirongxu commented Aug 31, 2024

Many unit tests assert that getDocument() return value is undefined.

https://github.com/neoclide/coc.nvim/actions/runs/10643037745/job/29506143934#step:9:59

@weirongxu
Copy link
Contributor Author

To prevent incompatibility, I think we should also declare both null and undefined.

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (d4ff928) to head (8b7233a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5132      +/-   ##
==========================================
- Coverage   98.39%   98.39%   -0.01%     
==========================================
  Files         273      273              
  Lines       26131    26131              
  Branches     5400     5400              
==========================================
- Hits        25712    25711       -1     
- Misses        258      259       +1     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit 9c25f2f into neoclide:master Aug 31, 2024
4 checks passed
fannheyward added a commit that referenced this pull request Sep 2, 2024
9c25f2f fix(typings): getDocument return type. (#5132)
d4ff928 feat(language-client): modify log time format (#5130)
53e21a9 fix(snippet): deviation in snippet select in the first column (#5104)
0e6a8c7 feat(codeLens): add codeLens.display (#5129)
704295e fix(handler): correct current winid (#5128)
aabfc23 fix: ignore failed config file reads (#5118)
56ea360 feat: expose more properties quick list (#5114)
37f98a1 feat(util): adjust to vim's Patch 9.1.327 (#5122)
80e9f1b chore(package): upgrade micromatch (#5127)
98fa66a chore(packages): lock ESLint versions for now (#5108)
bf3d1f6 Add `coc.preferences.formatterExtension` configuration (#5102)
38697bc chore(handle): typo toggle inlayHint (#5105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants