fix(schema.json): Added schema for coc.preference.renameFillCurrent #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the renameFillCurrent functionality in this PR (neoclide#3528) Missed adding the updates to the schema.json so LSP support wasn't working while editing coc-preferences.json. Hopefully this fixes that.
fannheyward
approved these changes
Jan 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #3553 +/- ##
=======================================
Coverage 74.72% 74.72%
=======================================
Files 191 191
Lines 19554 19554
Branches 4384 4384
=======================================
Hits 14612 14612
+ Misses 3166 3161 -5
- Partials 1776 1781 +5
Continue to review full report at Codecov.
|
chemzqm
added a commit
that referenced
this pull request
Jan 11, 2022
e8bbb87 feat(handler): change priority of document highlight 8f2a2dc better grammar (#3551) 6715c5b fix(schema.json): Added schema for coc.preference.renameFillCurrent (#3553) 3aeeb52 fix(doc): Typos (#3550) c7a20c8 refactor(completion): latestInsertChar alwayes to true (#3536) 77fb25a fix(sources): fix absolute filepath check on windows 7f2dd00 refactor(completion): support b:coc_disabled_sources 947589b chore(api): avoid unnecessary check 4a1cc23 fix(document): fix document change event not fired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tweaked the functionality to the rename feature in this PR (#3528).
It relies on the coc.preferences.renameFillCurrent setting in coc-preferences.json.
I missed adding this new key to
schema.jsonso LSP support wasn'tworking while editing
coc-preferences.json. Hopefully this fixes that.Thanks