Avoid nvim_win_get_position for window position to support multigrid ui #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fannheyward
approved these changes
Jun 19, 2021
chemzqm
changed the title
chemzqm
added a commit
that referenced
this pull request
Jun 22, 2021
91c1114 fix(diagnostic): avoid change range of diagnostics cad8c6b fix(workspace): fix range of getSelectedRange with line mode 18f81ab chore(picker): use await to avoid test fail 3efce54 fix(diagnostic): no more emptyRange check (#3147) 837941f fix float window position control to consider multigrid ui (#3150) 046505c test(ci): use node12 acd723d fix(completion): avoid unnecessary redraw for floating window (#3151) 10cfe59 docs: inconsistent suggest.triggerCompletionWait value (#3152) dafed9d fix: remove polyfill of Promise.prototyp.finally (#3153) 493ea2e fix(diagnostic): check diagnostic next to eol character 31e76d4 refactor(handler): fetch codelens for all buffers on CursorHold e47e472 fix(diagnostic): adjust diagnostic range which pass last line ba9c5c8 chore(yarn): upgrade esbuild.js 9b60af3 chore(bin): remove unnecessary check.js 179ca72 fix: typos found by github.com/crate-ci/typos (#3146) 70a7903 LSP 3.16.0 (#2756) 8cb6bdc fix(float): should give foldcolumn a default value (#3140) 171ff2b chore(bin): remove unnecessary check.js 1377f3b fix: yarn.lock (#3136)
This was referenced Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the scrollbar on the tooltip that coc.nvim pops up is not displayed in the correct position in the Neovim GUI that supports multigrid ui. See: akiyosi/goneovim#231
This fix resolves this issue.
The following is related information on this issue.