Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TableChart to use first row as titles when transposed #513

Closed
wants to merge 2 commits into from

Conversation

bastienhubert
Copy link
Collaborator

Hey, this PR is related to issue #428 , instead of adding another setting (in addition to "transpose" on/off), I choosed to automatically display first column as first row, when transpose option is choosen

Here is the initial display with transpose:

Capture d’écran 2023-07-13 à 11 44 46

Here is the current display with transpose:

Capture d’écran 2023-07-13 à 11 44 22

@bastienhubert bastienhubert changed the base branch from master to develop July 13, 2023 09:46
@bastienhubert bastienhubert linked an issue Jul 13, 2023 that may be closed by this pull request
@nielsdejong nielsdejong self-assigned this Jul 25, 2023
Copy link
Collaborator

@nielsdejong nielsdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, seems to be some edge cases in which this breaks:

UNWIND ["A","B"] as X
RETURN X as value

(no data visualized)

RETURN "A", "B"

Error: maximum call stack size exceeded.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@c01eb0c). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 0a156c7 differs from pull request most recent head 7208075. Consider uploading reports for the commit 7208075 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #513   +/-   ##
==========================================
  Coverage           ?   46.85%           
==========================================
  Files              ?      170           
  Lines              ?     6640           
  Branches           ?     2045           
==========================================
  Hits               ?     3111           
  Misses             ?     3488           
  Partials           ?       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BennuFire BennuFire mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Use the first row of the table as column keys
2 participants