fixed property smoothing (elalish#845)

ncthbrt · Jun 14, 2024 · 80a5f2e · 80a5f2e
1 parent 67c4647
commit 80a5f2e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -12,7 +12,7 @@
       "program": "${workspaceFolder}/build/test/manifold_test",
       "args": [
         "--gtest_break_on_failure",
-        "--gtest_filter=Smooth.TruncatedCone"
+        "--gtest_filter=Smooth.RefineQuads"
       ],
       "stopAtEntry": false,
       "cwd": "${workspaceFolder}/build/test",

diff --git a/src/manifold/src/manifold.cpp b/src/manifold/src/manifold.cpp
@@ -723,7 +723,7 @@ Manifold Manifold::SmoothOut(float minSharpAngle, float minSmoothness) const {
       Vec<glm::ivec3> triProperties = pImpl->meshRelation_.triProperties;
       pImpl->SetNormals(0, minSharpAngle);
       pImpl->CreateTangents(0);
-      pImpl->meshRelation_.numProp = 0;
+      pImpl->meshRelation_.numProp = numProp;
       pImpl->meshRelation_.properties.swap(properties);
       pImpl->meshRelation_.triProperties.swap(triProperties);
     } else {

diff --git a/test/smooth_test.cpp b/test/smooth_test.cpp
@@ -48,7 +48,8 @@ TEST(Smooth, Tetrahedron) {
 
 TEST(Smooth, RefineQuads) {
   Manifold cylinder =
-      Manifold(WithPositionColors(Manifold::Cylinder(2, 1, -1, 12).SmoothOut()))
+      Manifold(WithPositionColors(Manifold::Cylinder(2, 1, -1, 12)))
+          .SmoothOut()
           .RefineToLength(0.05);
   EXPECT_EQ(cylinder.NumTri(), 16892);
   auto prop = cylinder.GetProperties();