Skip to content

Commit

Permalink
Revert "usb: core: hcd: Create platform devices for onboard hubs in p…
Browse files Browse the repository at this point in the history
…robe()"

This reverts commit c40b622.

The series still has built errors as reported in linux-next, so revert
it for now.

Reported-by: Stephen Rothwell <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Cc: Stephen Boyd <[email protected]>
Cc: Douglas Anderson <[email protected]>
Cc: Matthias Kaehlcke <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed May 3, 2022
1 parent b9c92fb commit f2b6e79
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions drivers/usb/core/hcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include <linux/phy/phy.h>
#include <linux/usb.h>
#include <linux/usb/hcd.h>
#include <linux/usb/onboard_hub.h>
#include <linux/usb/otg.h>

#include "usb.h"
Expand Down Expand Up @@ -2985,9 +2984,6 @@ int usb_add_hcd(struct usb_hcd *hcd,
if (hcd->uses_new_polling && HCD_POLL_RH(hcd))
usb_hcd_poll_rh_status(hcd);

if (usb_hcd_is_primary_hcd(hcd))
onboard_hub_create_pdevs(hcd->self.root_hub, &hcd->onboard_hub_devs);

return retval;

err_register_root_hub:
Expand Down Expand Up @@ -3066,8 +3062,6 @@ void usb_remove_hcd(struct usb_hcd *hcd)
if (usb_hcd_is_primary_hcd(hcd)) {
if (hcd->irq > 0)
free_irq(hcd->irq, hcd);

onboard_hub_destroy_pdevs(&hcd->onboard_hub_devs);
}

usb_deregister_bus(&hcd->self);
Expand Down
1 change: 0 additions & 1 deletion include/linux/usb/hcd.h
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ struct usb_hcd {
struct usb_hcd *shared_hcd;
struct usb_hcd *primary_hcd;

struct list_head onboard_hub_devs;

#define HCD_BUFFER_POOLS 4
struct dma_pool *pool[HCD_BUFFER_POOLS];
Expand Down

0 comments on commit f2b6e79

Please sign in to comment.