Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full CMake build support and enabled CI #140

Closed
wants to merge 2 commits into from

Conversation

xvitaly
Copy link

@xvitaly xvitaly commented Apr 21, 2022

Changes:

  • Implemented full CMake support, based on our work:
    • builds, runs unit tests and installs project;
    • generates and exports CMake targets for external projects;
    • generates and exports pkg-config files for external projects;
  • Enabled GitHub actions and enabled CI for testing builds and running unit tests.
  • Removed no longer needed makefiles. CMake will automatically generate them for all supported platforms.

Build instructions:

cmake -S . -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_EXAMPLES:BOOL=ON -DBUILD_TESTS:BOOL=ON
cmake --build build

Installation instructions:

sudo cmake --install build

Closes #61.

xvitaly and others added 2 commits April 22, 2023 13:34
Co-authored-by: leha-bot <[email protected]>
Signed-off-by: Vitaly Zaitsev <[email protected]>
Signed-off-by: Vitaly Zaitsev <[email protected]>
@Conan-Kudo
Copy link

@nayuki why did you close this? It's incredibly useful and makes it so we can consume this easily.

@nayuki
Copy link
Owner

nayuki commented Aug 29, 2024

@Conan-Kudo It's a lot of new/changed code for a system that I do not understand. Rather than let this request languish, I made the decision to hard-close it because I know I will not have time to process it.

You might be wondering, why not accept it as is? Because that's not how I operate. I hold myself accountable for every line, every character of code. No feature escapes my supervision. You might see code as a feature, but I see code as a liability. Every piece of code is something that can go wrong, hide bugs, hide security vulnerabilities, and need ongoing maintenance as assumptions/environments/tools change.

Please try to understand my role as a maintainer. Accepting every proposal without question would be a disaster for any project. A line has to be drawn somewhere. I choose to be ultra-conservative and draw the line at exactly what code I understand. If I don't understand the code, there is a very high chance I will reject it.

@Conan-Kudo
Copy link

Sure, but wouldn't it make sense to at least ask questions and engage a little bit before deciding on that course? Because you might come away learning something new and useful that you can apply to even more contexts than this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No make install (cpp version)
3 participants