Tags are now case-sensitive, describe account lists tags associated with the account #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] describe accounts was not printing tags associated with the account
ripienaar
approved these changes
Sep 16, 2024
go.mod
Outdated
| @@ -52,3 +52,5 @@ require ( | |||
| gopkg.in/yaml.v2 v2.4.0 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/nats-io/jwt/v2 => github.com/nats-io/jwt/v2 v2.6.1-0.20240912200904-90d24c5a61af | |||
by itself nothing - the tags will be all lowercase on anything loaded. However, sloppy input on the cli will possibly create unexpected results. |
…is flag enables use of mix-case values on tags. If not specified and a tag value is mixed cased, the edit will be rejected. [FEAT] for `--rm-tag` options in operator/account/user, the operation will now fail if the value is not found the JWT.
|
After trying a couple of options settled on the change that JWT API uses are always case-sensitive as that can be telegraphed through the release notes. But for This will catch sloppy usages of the flag where values are not lowercase and request that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CHANGE] Tags (--tag and --rm-tag) are now case-sensitive
[FIX] describe accounts was not printing tags associated with the account
Fixes nats-io/nats-server#5681