Modify the project structure & update various portions #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle # gradle.properties
whoops i deleted a line or two too many
sschr15
changed the title
natanfudge
requested changes
Nov 12, 2022
natanfudge
reviewed
Nov 12, 2022
|
I seem to be getting this warning whenever I build when the test mod is included with Can we do anything about this? |
|
It seems like loom just doesn't work very well when referencing other subprojects. Don't add that stuff for now (keep TESTING.md as-is as well). |
natanfudge
approved these changes
Nov 12, 2022
| def cf = libs.versions.overrides.curseforge.get() | ||
| def mr = libs.versions.overrides.modrinth.get() | ||
|
|
||
| ext.curseforge_mc_version = cf == 'mc' ? minecraft_version : cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle/libs.versions.tomlTest mods and individual modules are less likely to fall out of sync with each other now, and with one single version location management, it is likely a lot easier to update versions in the future.