3.1.7

changelog.md

@@ -1,3 +1,5 @@
+### 3.1.7
+- Added a new config option: debugModIdentification, that will hopefully help in discovering mods in more cases.
 ### 3.1.6
 - (Forge) Fixed being unable to identify crashing mods that have multiple authors.
 ### 3.1.5

common/src/main/java/fudge/notenoughcrashes/ModConfig.java

@@ -20,6 +20,7 @@ public enum CrashLogUploadType {
     public CrashLogUploadType uploadCrashLogTo = CrashLogUploadType.GIST;
     public boolean disableReturnToMainMenu = false;
     public boolean deobfuscateStackTrace = true;
+    public boolean debugModIdentification = false;
 
     public static ModConfig instance() {
         if (instance != null) {

common/src/main/java/fudge/notenoughcrashes/stacktrace/ModIdentifier.java

@@ -1,5 +1,7 @@
 package fudge.notenoughcrashes.stacktrace;
 
+import fudge.notenoughcrashes.ModConfig;
+import fudge.notenoughcrashes.NotEnoughCrashes;
 import fudge.notenoughcrashes.platform.CommonModMetadata;
 import fudge.notenoughcrashes.platform.NecPlatform;
 import org.apache.logging.log4j.LogManager;
@@ -52,18 +54,29 @@ private static Set<CommonModMetadata> identifyFromThrowable(Throwable e) {
         return mods;
     }
 
+    private static final boolean debugLog = true;
+
+    private static void debug(String message) {
+        if (ModConfig.instance().debugModIdentification) NotEnoughCrashes.LOGGER.info(message);
+    }
+
     // TODO: get a list of mixin transformers that affected the class and blame those too
     private static Set<CommonModMetadata> identifyFromClass(String className, Map<URI, Set<CommonModMetadata>> modMap) {
+        debug("Analyzing " + className);
         // Skip identification for Mixin, one's mod copy of the library is shared with all other mods
         if (className.startsWith("org.spongepowered.asm.mixin.")) {
+            debug("Ignoring class " + className + " for identification because it is a mixin class");
             return Collections.emptySet();
         }
 
         try {
             // Get the URL of the class
             Class<?> clazz = Class.forName(className);
             CodeSource codeSource = clazz.getProtectionDomain().getCodeSource();
-            if (codeSource == null) return Collections.emptySet(); // Some internal native sun classes
+            if (codeSource == null) {
+                debug("Ignoring class " + className + " for identification because the code source could not be found");
+                return Collections.emptySet(); // Some internal native sun classes
+            }
             URL url = codeSource.getLocation();
 
             if (url == null) {
@@ -92,6 +105,10 @@ private static Set<CommonModMetadata> identifyFromClass(String className, Map<UR
             // Get the mod containing that class
             return metadata;
         } catch (URISyntaxException | IOException | ClassNotFoundException | NoClassDefFoundError e) {
+            debug("Ignoring class " + className + " for identification because an error occurred");
+            if (debugLog) {
+                e.printStackTrace();
+            }
             return Collections.emptySet(); // we cannot do it
         }
     }

gradle.properties

@@ -2,7 +2,7 @@ org.gradle.jvmargs=-Xmx2048M
 
 
 archives_base_name=notenoughcrashes
-mod_version=3.1.6
+mod_version=3.1.7
 maven_group=fudge.notenoughcrashes
 
 architectury_version=1.4.91