This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
Use opportunistic zero-copy strategy in send
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `ffi.from_buffer` more aggressively when the data type and CFFI version support it. Older versions of CFFI don't support commonly used types like `bytes` but do work for some variants of `memoryview`. Instead of instance and version checking all the permutations this patch attempts the fast path first and catches `TypeError` as a condition to degrade to the slow path of `ffi.new`. See: http://cffi.readthedocs.io/en/latest/ref.html#ffi-buffer-ffi-from-buffer Fixes nanomsg#34
|
Thank you for getting this done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ffi.from_buffermore aggressively when the data type and CFFI versionsupport it. Older versions of CFFI don't support commonly used types
like
bytesbut do work for some variants ofmemoryview. Instead ofinstance and version checking all the permutations this patch attempts the
fast path first and catches
TypeErroras a condition to degrade to the slowpath of
ffi.new.See: http://cffi.readthedocs.io/en/latest/ref.html#ffi-buffer-ffi-from-buffer
Fixes #34