Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix completion on $input.item. in Code node #10800

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 12, 2024

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1717/typing-dollarinputitem-does-not-show-binary-and-json-autocomplete

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 12, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Sep 12, 2024

n8n    Run #6860

Run Properties:  status check passed Passed #6860  •  git commit d750e3928a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1717-typing-inputitem-does-not-show-binary-and-json-autocomplete
Run status status check passed Passed #6860
Run duration 04m 39s
Commit git commit d750e3928a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 429
View all changes introduced in this branch ↗︎

@elsmr elsmr merged commit 45dccf3 into master Sep 13, 2024
32 checks passed
@elsmr elsmr deleted the node-1717-typing-inputitem-does-not-show-binary-and-json-autocomplete branch September 13, 2024 06:36
MiloradFilipovic added a commit that referenced this pull request Sep 13, 2024
* master:
  fix(editor): Fix completion on $input.item. in Code node (#10800)
  feat(OpenAI Node): Include O1 models in the models select (#10801)
  build: Disable `node-param-collection-type-unsorted-items` for langchain nodes (no-changelog) (#10802)
  fix(editor): Render the current first in CollaborationPane (no-changelog) (#10799)
  refactor(core): Enable import/order eslint rule (#10794)
  fix(benchmark): Fix benchmark license tenant (#10798)
  build: Upgrade nodelinter to 1.16.2 (no-changelog) (#10779)
  refactor(core): Migrate `Modal.vue` to composition API (no-changelog) (#10792)
  ci(benchmark): Run 3 times a night to account for fluctuations (#10791)
  refactor(editor): Convert `NodeExecuteButton` to composition api (#10703)
  refactor(benchmark): Use kebab-case for file and directory names (#10787)
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants