[code-infra] Add missing @babel/runtime dependency to @mui/material-pigment-css #43473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43473--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
Janpot
commented
Aug 27, 2024
| @@ -93,7 +93,7 @@ module.exports = function getBabelConfig(api) { | |||
| { | |||
| useESModules, | |||
| // any package needs to declare 7.25.0 as a runtime dependency. default is ^7.0.0 | |||
| version: '^7.25.0', | |||
| version: process.env.MUI_BABEL_RUNTIME_VERSION || '^7.25.0', | |||
There was a problem hiding this comment.
Not 100% satisfied with this solution but the babel config is used both by our build and by babel-node. MUI_BABEL_RUNTIME_VERSION may not always be defined. This seemed to be the lesser of evils, the existence is already checked in the build script
This was referenced Aug 27, 2024
LukasTy
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #43264, where this was breaking a build. Took the opportunity to add a check for missing
@babel/runtimedependencies. As suggested in #43243 I'm passing this version to babel config to be used in the build.