[test] Make conformance tests work with async render function #43156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43156--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Aug 4, 2024
michaldudak
force-pushed
the
fix-flushMicrotasks
branch
from
f4b4d74
to
a09cbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flushMicrotasksfunction was incorrectly skipped during browser (karma) tests. I initially thought that the errors it throws on this environment are caused by specifics of karma. However, it turns out these errors were valid and indicated a bigger problem - the lack of support for async render functions in conformance tests.This PR fixes both the
flushMicrotasksfunction, making it run regardless of the environment, and conformance tests, to support async render functions (required in Menu and Select tests, plus many more in the future once @base_ui/react is used).