Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui][Card] Update CardMedia description #43067

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

shahzaibdev1
Copy link
Contributor

@shahzaibdev1 shahzaibdev1 commented Jul 25, 2024

Fixes #42859

This is my first contribution to open-source projects, please inform me if something's wrong by my side. I want to contribute to MUI as it's my fav project.

This is to update the issue mui#42859. [docs][material-ui][Card] CardMedia description is wrong 

This is my first contribution to open-source projects, please inform me if something's wrong by my side. I want to contribute to MUI as it's my fav project.

Signed-off-by: shahzaibdev1 <[email protected]>
@mui-bot
Copy link

mui-bot commented Jul 25, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 82c9db6

@shahzaibdev1 shahzaibdev1 marked this pull request as draft July 25, 2024 09:34
@shahzaibdev1 shahzaibdev1 marked this pull request as ready for review July 25, 2024 09:35
@zannager zannager added docs Improvements or additions to the documentation component: card This is the name of the generic UI component, not the React module! labels Jul 25, 2024
@aarongarciah aarongarciah added the package: material-ui Specific to @mui/material label Jul 25, 2024
@aarongarciah aarongarciah changed the title Update cards.md [material-ui][docs][Card] Update CardMedia description Jul 25, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs][Card] Update CardMedia description [docs][material-ui][Card] Update CardMedia description Jul 29, 2024
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Jul 29, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge label Jul 30, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ZeeshanTamboli ZeeshanTamboli merged commit f160039 into mui:next Jul 30, 2024
19 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: shahzaibdev1 <[email protected]>
Co-authored-by: Aarón García Hervás <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: card This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][material-ui][Card] CardMedia description is wrong
6 participants