Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Better support for theme.props #11688

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 2, 2018

Closes #11665
Allow the usage of custom default values without a prop-type warning:

const theme = createMuiTheme({
  props: {
    // Name of the component ⚛️
    MuiGrid: {
      // The properties to apply
      spacing: 8,
    },
  },
});

@oliviertassinari oliviertassinari force-pushed the grid-better-support-for-theme-props branch from 7ae6121 to 8373a43 Compare June 2, 2018 17:28
@oliviertassinari oliviertassinari merged commit 64b4dac into mui:master Jun 2, 2018
@oliviertassinari oliviertassinari deleted the grid-better-support-for-theme-props branch June 2, 2018 17:37
@fondberg
Copy link
Contributor

fondberg commented Jun 3, 2018

👍

acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants