GIT-2986: Fixed incorrect display of room recordings title (Fixes big…

…bluebutton#2986). (bigbluebutton#3003)

Co-authored-by: Ahmad Farhat <[email protected]>

app/helpers/application_helper.rb

@@ -152,4 +152,9 @@ def perm_to_record_meeting
   def protected_recording?(rec)
     !rec[:protected].nil?
   end
+
+  # Takes any expression and stringify it decoding any html charachter entity if found.
+  def html_entities_decode(expr)
+    CGI.unescapeHTML expr
+  end
 end

app/views/shared/components/_public_recording_row.html.erb

@@ -18,10 +18,10 @@
     <div id="recording-title" class="edit_hover_class" data-recordid="<%= recording[:recordID] %>" data-room-uid="<%= room_uid_from_bbb(recording[:meetingID]) %>" data-path="<%= rename_recording_path(meetingID: recording[:meetingID], record_id: recording[:recordID]) %>">
       <% if recording[:metadata][:name] %>
         <span id="recording-text" title="<%= recording[:metadata][:name] %>">
-          <%= recording[:metadata][:name] %>
+          <%= html_entities_decode(recording[:metadata][:name]) %>
       <% else %>
         <span id="recording-text" title="<%= recording[:name] %>">
-          <%= recording[:name] %>
+          <%= html_entities_decode(recording[:name]) %>
       <% end %>
         </span>
     </div>

app/views/shared/components/_recording_row.html.erb

@@ -18,10 +18,10 @@
     <div id="recording-title" class="edit_hover_class" data-recordid="<%= recording[:recordID] %>" data-room-uid="<%= room_uid_from_bbb(recording[:meetingID]) %>" data-path="<%= rename_recording_path(meetingID: recording[:meetingID], record_id: recording[:recordID]) %>">
       <% if recording[:metadata][:name] %>
         <span id='recording-text' title="<%= recording[:metadata][:name] %>">
-          <%= recording[:metadata][:name] %>
+          <%= html_entities_decode(recording[:metadata][:name]) %>
       <% else %>
         <span id='recording-text' title="<%= recording[:name] %>">
-          <%= recording[:name] %>
+          <%= html_entities_decode(recording[:name]) %>
       <% end %>
         </span>
       <a><i id="edit-record" class="fa fa-edit align-top ml-2" data-edit-recordid="<%= recording[:recordID] %>"></i></a>

spec/helpers/application_helper_spec.rb

@@ -27,7 +27,21 @@
       expect(helper.omniauth_login_url(provider)).to eql("/b/auth/#{provider}")
     end
   end
-
+  describe "#html_decode" do
+    let(:expr_with_html_entities) { '<>&"' }
+    let(:expr_with_html_entities_decoded) { '<>&"' }
+    let(:expr_with_no_html_entities) { "this is some regular text!!" }
+    context "with html charachter entities" do
+     it "should return the decoded version of the expression" do
+       expect(html_entities_decode(expr_with_html_entities)).to eq(expr_with_html_entities_decoded)
+     end
+    end
+    context "with no html charachter entities" do
+      it "should return the expression stringified" do
+        expect(html_entities_decode(expr_with_no_html_entities)).to eq(expr_with_no_html_entities)
+      end
+    end
+  end
   describe "role_colur" do
     it "should use default if the user doesn't have a role" do
       expect(helper.role_colour(Role.create(name: "test"))).to eq(Rails.configuration.primary_color_default)