Skip to content
This repository has been archived by the owner on Jul 18, 2020. It is now read-only.

fix code block on mobile #25

Merged
merged 1 commit into from
Jan 29, 2014
Merged

fix code block on mobile #25

merged 1 commit into from
Jan 29, 2014

Conversation

zerongjiang
Copy link
Contributor

Hey, I like how the .highlight code block looks like. It's like a silk gift wrap.

But there's too much padding on the left, when nested in a list or on a small screen.

And the <ul> tag on chrome has -webkit-padding-start set to 40px. The reset is added.

I updated the style.scss a little bit.

I've tested it on different screen size. It would affect the layout on bigger screens.

Thanks.

Before.

2014-01-28-230741_320x516_scrot

After.

2014-01-28-230736_320x516_scrot

@muan
Copy link
Owner

muan commented Jan 29, 2014

Hi there, since these are changes are for small screens only, could you add them to https://github.com/muan/scribble/blob/master/_assets/responsive.scss instead?

@zerongjiang
Copy link
Contributor Author

Hi, i tried to add style to responsive.scss first. But there's also problem for nested fenced code block in a list. See screenshot below:

So i think instead of add padding to the <pre> tag, why not just remove the not(.hightlight) from the following line and keep it all the same to the elements under .post.

I didn't mean to break the structure of sass, but seems like a better solution.

> *:not(.highlight) { padding: 0 60px; }

2014-01-29-004305_800x568_scrot

@muan
Copy link
Owner

muan commented Jan 29, 2014

Ah, you are right. This makes sense. Thank you! :)

muan added a commit that referenced this pull request Jan 29, 2014
@muan muan merged commit ca5e0e4 into muan:master Jan 29, 2014
@zerongjiang
Copy link
Contributor Author

; )

Happy Chinese New Year !

             /\,%,_
              \%%%/,\
            _.-"%%|//%
          .'  .-"  /%%%
      _.-'_.-" 0)   \%%%
     /.\.'           \%%%
     \ /      _,      %%%
      `"---"~`\   _,*'\%%'   _,--""""-,%%,
               )*^     `""~~`          \%%%,
             _/                         \%%%
         _.-`/                           |%%,___
     _.-"   /      ,           ,        ,|%%   .`\
    /\     /      /             `\       \%'   \ /
    \ \ _,/      /`~-._         _,`\      \`""~~`
     `"` /-.,_ /'      `~"----"~    `\     \
         \___,'                       \.-"`/
                                       `--'

@muan
Copy link
Owner

muan commented Jan 29, 2014

🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍🎍🎍🎍📕📕🎍🎍🎍🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍🎍🎍📕📕📕📕🎍🎍🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍🎍📕📕📕📕📕📕🎍🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍📕📕📕📕📕📕📕📕🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍📕💛💛💛💛💛📕📕📕📕🎍🎍🎍🎍🎍
🎍🎍🎍🎍📕📕💛📕💛📕💛📕💛📕📕📕🎍🎍🎍🎍
🎍🎍🎍📕📕📕💛💛💛💛💛📕💛📕📕📕📕🎍🎍🎍
🎍🎍📕📕📕📕💛📕💛📕💛📕💛📕💛📕📕📕🎍🎍
🎍📕📕📕📕📕💛💛💛💛💛📕💛💛📕📕📕📕📕🎍
📕📕📕📕📕📕📕💛💛💛📕📕💛📕📕📕📕📕📕📕
🎍📕📕📕📕📕📕💛📕💛📕📕💛💛💛📕📕📕📕🎍
🎍🎍📕📕📕📕📕💛💛💛📕📕📕📕📕📕📕📕🎍🎍
🎍🎍🎍📕📕📕📕📕📕📕📕📕💛📕📕📕📕🎍🎍🎍
🎍🎍🎍🎍📕📕📕💛💛💛💛📕📕💛📕📕🎍🎍🎍🎍
🎍🎍🎍🎍🎍📕📕📕📕📕📕📕📕📕📕🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍📕📕📕📕📕📕📕📕🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍🎍📕📕📕📕📕📕🎍🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍🎍🎍📕📕📕📕🎍🎍🎍🎍🎍🎍🎍🎍
🎍🎍🎍🎍🎍🎍🎍🎍🎍📕📕🎍🎍🎍🎍🎍🎍🎍🎍🎍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants