Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary password prompt on mysql driver connection strings #1086

Merged

Conversation

dyegoaurelio
Copy link
Contributor

Describe here what is this PR about and what we are achieving merging this.

the extension was prompting for Driver Credentials even when connecting with connection strings


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@gjsjohnmurray gjsjohnmurray merged commit 3af4cb6 into mtxr:dev Jan 6, 2023
@dyegoaurelio dyegoaurelio deleted the fix-mysql-unnecessary-password-prompt branch January 6, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants