Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filter): keep relative paths when filtering #60

Merged
merged 3 commits into from
Aug 13, 2023
Merged

fix(filter): keep relative paths when filtering #60

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f478cca
fix(coverde): keep relative paths when filtering
mrverdant13 Aug 13, 2023
8e1a786
test(coverde): check expected file content
mrverdant13 Aug 13, 2023
8755a62
docs: update changelog
mrverdant13 Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(coverde): check expected file content
  • Loading branch information
@mrverdant13
mrverdant13 committed Aug 13, 2023
commit 8e1a7862d34a1822a0274dba1695abb257bc0ca9
38 changes: 32 additions & 6 deletions packages/coverde_cli/test/src/commands/filter/filter_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:convert';

import 'package:args/command_runner.dart';
import 'package:coverde/src/commands/filter/filter.dart';
import 'package:coverde/src/entities/tracefile.dart';
Expand Down Expand Up @@ -79,8 +81,11 @@ THEN a filtered tracefile should be created
final patternsRegex = patterns.map(RegExp.new);
final originalFilePath = 'original.lcov.info'.fixturePath;
final filteredFilePath = 'unquoted.filtered.lcov.info'.fixturePath;
final expectedFilteredFilePath =
'expected.unquoted.filtered.lcov.info'.fixturePath;
final originalFile = File(originalFilePath);
final filteredFile = File(filteredFilePath);
final expectedFilteredFile = File(expectedFilteredFilePath);
if (filteredFile.existsSync()) {
filteredFile.deleteSync(recursive: true);
}
Expand Down Expand Up @@ -112,12 +117,21 @@ THEN a filtered tracefile should be created
]);

// ASSERT
const splitter = LineSplitter();
expect(originalFile.existsSync(), isTrue);
expect(filteredFile.existsSync(), isTrue);
final filteredFileIncludeFileThatMatchPatterns = Tracefile.parse(
filteredFile.readAsStringSync(),
).includeFileThatMatchPatterns(patterns);
final filteredFileContent = filteredFile.readAsStringSync();
final expectedFilteredFileContent =
expectedFilteredFile.readAsStringSync();
final filteredFileIncludeFileThatMatchPatterns =
Tracefile.parse(filteredFileContent)
.includeFileThatMatchPatterns(patterns);
expect(filteredFileIncludeFileThatMatchPatterns, isFalse);
expect(
splitter.convert(filteredFileContent),
splitter.convert(expectedFilteredFileContent),
reason: 'Error: Non-matching filtered file content.',
);
for (final fileData in filesDataToBeRemoved) {
final path = fileData.source.path;
verify(
Expand All @@ -142,8 +156,11 @@ THEN a filtered tracefile should be created
final patternsRegex = patterns.map(RegExp.new);
final originalFilePath = 'original.lcov.info'.fixturePath;
final filteredFilePath = 'raw.filtered.lcov.info'.fixturePath;
final expectedFilteredFilePath =
'expected.raw.filtered.lcov.info'.fixturePath;
final originalFile = File(originalFilePath);
final filteredFile = File(filteredFilePath);
final expectedFilteredFile = File(expectedFilteredFilePath);
if (filteredFile.existsSync()) {
filteredFile.deleteSync(recursive: true);
}
Expand Down Expand Up @@ -175,12 +192,21 @@ THEN a filtered tracefile should be created
]);

// ASSERT
const splitter = LineSplitter();
expect(originalFile.existsSync(), isTrue);
expect(filteredFile.existsSync(), isTrue);
final filteredFileIncludeFileThatMatchPatterns = Tracefile.parse(
filteredFile.readAsStringSync(),
).includeFileThatMatchPatterns(patterns);
final filteredFileContent = filteredFile.readAsStringSync();
final expectedFilteredFileContent =
expectedFilteredFile.readAsStringSync();
final filteredFileIncludeFileThatMatchPatterns =
Tracefile.parse(filteredFileContent)
.includeFileThatMatchPatterns(patterns);
expect(filteredFileIncludeFileThatMatchPatterns, isFalse);
expect(
splitter.convert(filteredFileContent),
splitter.convert(expectedFilteredFileContent),
reason: 'Error: Non-matching filtered file content.',
);
for (final fileData in filesDataToBeRemoved) {
final path = fileData.source.path;
verify(
Expand Down
Loading