Skip to content

Commit

Permalink
[PATCH] ppc32: MPC834x BCSR_SIZE too small for use in a BAT.
Browse files Browse the repository at this point in the history
The call to io_block_mapping was creating an invalid BAT entry because the
value of BCSR_SIZE (32K) is too small to be used in a BAT (128K min).  This
change removes the io_block_mapping call since these registers can easily
be mapped using ioremap at the point of use.

Signed-off-by: Randy Vinson <[email protected]>
Signed-off-by: Kumar Gala <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Kumar Gala authored and Linus Torvalds committed May 28, 2005
1 parent 92b4dc1 commit ff94502
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion arch/ppc/platforms/83xx/mpc834x_sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ mpc834x_sys_map_io(void)
{
/* we steal the lowest ioremap addr for virt space */
io_block_mapping(VIRT_IMMRBAR, immrbar, 1024*1024, _PAGE_IO);
io_block_mapping(BCSR_VIRT_ADDR, BCSR_PHYS_ADDR, BCSR_SIZE, _PAGE_IO);
}

int
Expand Down
1 change: 0 additions & 1 deletion arch/ppc/platforms/83xx/mpc834x_sys.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#define VIRT_IMMRBAR ((uint)0xfe000000)

#define BCSR_PHYS_ADDR ((uint)0xf8000000)
#define BCSR_VIRT_ADDR ((uint)0xfe100000)
#define BCSR_SIZE ((uint)(32 * 1024))

#ifdef CONFIG_PCI
Expand Down

0 comments on commit ff94502

Please sign in to comment.