bridge: remove rtmsg_ifinfo called in add_del_if

Since commit dc709f3 ("rtnetlink: bring NETDEV_CHANGEUPPER event process back in rtnetlink_event"), rtnetlink_event would process the NETDEV_CHANGEUPPER event and send a notification to userspace. In add_del_if, it would generate NETDEV_CHANGEUPPER event by whether netdev_master_upper_dev_link or netdev_upper_dev_unlink. There's no need to call rtmsg_ifinfo to send the notification any more. So this patch is to remove it from add_del_if also to avoid redundant notifications. Signed-off-by: Xin Long <[email protected]> Signed-off-by: David S. Miller <[email protected]>
mrcsosa · Oct 25, 2017 · fbb85b3 · fbb85b3
1 parent d458821
commit fbb85b3
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/net/bridge/br_ioctl.c b/net/bridge/br_ioctl.c
@@ -102,9 +102,6 @@ static int add_del_if(struct net_bridge *br, int ifindex, int isadd)
 	else
 		ret = br_del_if(br, dev);
 
-	if (!ret)
-		rtmsg_ifinfo(RTM_NEWLINK, dev, IFF_MASTER, GFP_KERNEL);
-
 	return ret;
 }