Skip to content

Commit

Permalink
mm: Initialize error in shmem_file_aio_read()
Browse files Browse the repository at this point in the history
Some versions of gcc even warn about it:

  mm/shmem.c: In function ‘shmem_file_aio_read’:
  mm/shmem.c:1414: warning: ‘error’ may be used uninitialized in this function

If the loop is aborted during the first iteration by one of the two
first break statements, error will be uninitialized.

Introduced by commit 6e58e79 ("introduce copy_page_to_iter, kill
loop over iovec in generic_file_aio_read()").

Signed-off-by: Geert Uytterhoeven <[email protected]>
Acked-by: Al Viro <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
geertu authored and torvalds committed Apr 13, 2014
1 parent e686bd8 commit f7c1d07
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/shmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ static ssize_t shmem_file_aio_read(struct kiocb *iocb,
pgoff_t index;
unsigned long offset;
enum sgp_type sgp = SGP_READ;
int error;
int error = 0;
ssize_t retval;
size_t count;
loff_t *ppos = &iocb->ki_pos;
Expand Down

0 comments on commit f7c1d07

Please sign in to comment.