Skip to content

Commit

Permalink
[SERIAL] SUNHV: Fix jerky console on LDOM guests.
Browse files Browse the repository at this point in the history
Mixing putchar() and write() hvcalls does not work %100
correctly.  But we should be using write() all the time
if we can, even from ->start_tx(), anyways.

Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
David S. Miller committed Jul 17, 2007
1 parent 778feeb commit f798634
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions drivers/serial/sunhv.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,17 +258,7 @@ static void sunhv_stop_tx(struct uart_port *port)
/* port->lock held by caller. */
static void sunhv_start_tx(struct uart_port *port)
{
struct circ_buf *xmit = &port->info->xmit;

while (!uart_circ_empty(xmit)) {
long status = sun4v_con_putchar(xmit->buf[xmit->tail]);

if (status != HV_EOK)
break;

xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
port->icount.tx++;
}
transmit_chars(port);
}

/* port->lock is not held. */
Expand Down

0 comments on commit f798634

Please sign in to comment.