Skip to content

Commit

Permalink
XFS: xfs_trans_add_item() - don't assign in ASSERT() when compare is …
Browse files Browse the repository at this point in the history
…intended

It looks to me like the two ASSERT()s in xfs_trans_add_item() really
want to do a compare (==) rather than assignment (=).
This patch changes it from the latter to the former.

Signed-off-by: Jesper Juhl <[email protected]>
Signed-off-by: Ben Myers <[email protected]>

(cherry picked from commit 0529348)
  • Loading branch information
jjuhl authored and Ben Myers committed Feb 13, 2012
1 parent 92b2e5b commit f65020a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/xfs/xfs_trans.c
Original file line number Diff line number Diff line change
Expand Up @@ -1151,8 +1151,8 @@ xfs_trans_add_item(
{
struct xfs_log_item_desc *lidp;

ASSERT(lip->li_mountp = tp->t_mountp);
ASSERT(lip->li_ailp = tp->t_mountp->m_ail);
ASSERT(lip->li_mountp == tp->t_mountp);
ASSERT(lip->li_ailp == tp->t_mountp->m_ail);

lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS);

Expand Down

0 comments on commit f65020a

Please sign in to comment.