Skip to content

Commit

Permalink
lguest: move last_pages to lg_cpu
Browse files Browse the repository at this point in the history
in our new model, pages are assigned to a virtual cpu, not to a guest.
We move it to the lg_cpu structure.

Signed-off-by: Glauber de Oliveira Costa <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
Glauber de Oliveira Costa authored and rustyrussell committed Jan 30, 2008
1 parent c40a9f4 commit f34f8c5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
3 changes: 2 additions & 1 deletion drivers/lguest/lg.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ struct lg_cpu {
unsigned long regs_page;
struct lguest_regs *regs;

struct lguest_pages *last_pages;

int cpu_pgd; /* which pgd this cpu is currently using */

/* If a hypercall was asked for, this points to the arguments. */
Expand Down Expand Up @@ -92,7 +94,6 @@ struct lguest

/* Bitmap of what has changed: see CHANGED_* above. */
int changed;
struct lguest_pages *last_pages;

struct pgdir pgdirs[4];

Expand Down
8 changes: 4 additions & 4 deletions drivers/lguest/lguest_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ static int lg_cpu_start(struct lg_cpu *cpu, unsigned id, unsigned long start_ip)
* reference, it is destroyed before close() is called. */
cpu->mm = get_task_mm(cpu->tsk);

/* We remember which CPU's pages this Guest used last, for optimization
* when the same Guest runs on the same CPU twice. */
cpu->last_pages = NULL;

return 0;
}

Expand Down Expand Up @@ -192,10 +196,6 @@ static int initialize(struct file *file, const unsigned long __user *input)
if (err)
goto free_regs;

/* We remember which CPU's pages this Guest used last, for optimization
* when the same Guest runs on the same CPU twice. */
lg->last_pages = NULL;

/* We keep our "struct lguest" in the file's private_data. */
file->private_data = lg;

Expand Down
4 changes: 2 additions & 2 deletions drivers/lguest/x86/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ static void copy_in_guest_info(struct lg_cpu *cpu, struct lguest_pages *pages)
* same Guest we ran last time (and that Guest hasn't run anywhere else
* meanwhile). If that's not the case, we pretend everything in the
* Guest has changed. */
if (__get_cpu_var(last_cpu) != cpu || lg->last_pages != pages) {
if (__get_cpu_var(last_cpu) != cpu || cpu->last_pages != pages) {
__get_cpu_var(last_cpu) = cpu;
lg->last_pages = pages;
cpu->last_pages = pages;
lg->changed = CHANGED_ALL;
}

Expand Down

0 comments on commit f34f8c5

Please sign in to comment.