Skip to content

Commit

Permalink
RDS: remove __init and __exit annotation
Browse files Browse the repository at this point in the history
The trivial amount of memory saved isn't worth the cost of dealing with section
mismatches.

Signed-off-by: Zach Brown <[email protected]>
  • Loading branch information
Zach Brown authored and Andy Grover committed Sep 9, 2010
1 parent c20f5b9 commit ef87b7e
Show file tree
Hide file tree
Showing 20 changed files with 35 additions and 35 deletions.
4 changes: 2 additions & 2 deletions net/rds/af_rds.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ static void rds_sock_info(struct socket *sock, unsigned int len,
spin_unlock_irqrestore(&rds_sock_lock, flags);
}

static void __exit rds_exit(void)
static void rds_exit(void)
{
sock_unregister(rds_family_ops.family);
proto_unregister(&rds_proto);
Expand All @@ -536,7 +536,7 @@ static void __exit rds_exit(void)
}
module_exit(rds_exit);

static int __init rds_init(void)
static int rds_init(void)
{
int ret;

Expand Down
2 changes: 1 addition & 1 deletion net/rds/connection.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ static void rds_conn_info(struct socket *sock, unsigned int len,
sizeof(struct rds_info_connection));
}

int __init rds_conn_init(void)
int rds_conn_init(void)
{
rds_conn_slab = kmem_cache_create("rds_connection",
sizeof(struct rds_connection),
Expand Down
2 changes: 1 addition & 1 deletion net/rds/ib.c
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ struct rds_transport rds_ib_transport = {
.t_type = RDS_TRANS_IB
};

int __init rds_ib_init(void)
int rds_ib_init(void)
{
int ret;

Expand Down
10 changes: 5 additions & 5 deletions net/rds/ib.h
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ void rds_ib_conn_free(void *arg);
int rds_ib_conn_connect(struct rds_connection *conn);
void rds_ib_conn_shutdown(struct rds_connection *conn);
void rds_ib_state_change(struct sock *sk);
int __init rds_ib_listen_init(void);
int rds_ib_listen_init(void);
void rds_ib_listen_stop(void);
void __rds_ib_conn_error(struct rds_connection *conn, const char *, ...);
int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
Expand All @@ -308,11 +308,11 @@ void *rds_ib_get_mr(struct scatterlist *sg, unsigned long nents,
void rds_ib_sync_mr(void *trans_private, int dir);
void rds_ib_free_mr(void *trans_private, int invalidate);
void rds_ib_flush_mrs(void);
int __init rds_ib_fmr_init(void);
void __exit rds_ib_fmr_exit(void);
int rds_ib_fmr_init(void);
void rds_ib_fmr_exit(void);

/* ib_recv.c */
int __init rds_ib_recv_init(void);
int rds_ib_recv_init(void);
void rds_ib_recv_exit(void);
int rds_ib_recv(struct rds_connection *conn);
int rds_ib_recv_alloc_caches(struct rds_ib_connection *ic);
Expand Down Expand Up @@ -363,7 +363,7 @@ unsigned int rds_ib_stats_info_copy(struct rds_info_iterator *iter,
unsigned int avail);

/* ib_sysctl.c */
int __init rds_ib_sysctl_init(void);
int rds_ib_sysctl_init(void);
void rds_ib_sysctl_exit(void);
extern unsigned long rds_ib_sysctl_max_send_wr;
extern unsigned long rds_ib_sysctl_max_recv_wr;
Expand Down
4 changes: 2 additions & 2 deletions net/rds/ib_rdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ static int rds_ib_flush_mr_pool(struct rds_ib_mr_pool *pool,

struct workqueue_struct *rds_ib_fmr_wq;

int __init rds_ib_fmr_init(void)
int rds_ib_fmr_init(void)
{
rds_ib_fmr_wq = create_workqueue("rds_fmr_flushd");
if (!rds_ib_fmr_wq)
Expand All @@ -706,7 +706,7 @@ int __init rds_ib_fmr_init(void)
* had their pools freed. As each pool is freed its work struct is waited on,
* so the pool flushing work queue should be idle by the time we get here.
*/
void __exit rds_ib_fmr_exit(void)
void rds_ib_fmr_exit(void)
{
destroy_workqueue(rds_ib_fmr_wq);
}
Expand Down
2 changes: 1 addition & 1 deletion net/rds/ib_recv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ int rds_ib_recv(struct rds_connection *conn)
return ret;
}

int __init rds_ib_recv_init(void)
int rds_ib_recv_init(void)
{
struct sysinfo si;
int ret = -ENOMEM;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/ib_sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ void rds_ib_sysctl_exit(void)
unregister_sysctl_table(rds_ib_sysctl_hdr);
}

int __init rds_ib_sysctl_init(void)
int rds_ib_sysctl_init(void)
{
rds_ib_sysctl_hdr = register_sysctl_paths(rds_ib_sysctl_path, rds_ib_sysctl_table);
if (!rds_ib_sysctl_hdr)
Expand Down
2 changes: 1 addition & 1 deletion net/rds/iw.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ struct rds_transport rds_iw_transport = {
.t_prefer_loopback = 1,
};

int __init rds_iw_init(void)
int rds_iw_init(void)
{
int ret;

Expand Down
6 changes: 3 additions & 3 deletions net/rds/iw.h
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ void rds_iw_conn_free(void *arg);
int rds_iw_conn_connect(struct rds_connection *conn);
void rds_iw_conn_shutdown(struct rds_connection *conn);
void rds_iw_state_change(struct sock *sk);
int __init rds_iw_listen_init(void);
int rds_iw_listen_init(void);
void rds_iw_listen_stop(void);
void __rds_iw_conn_error(struct rds_connection *conn, const char *, ...);
int rds_iw_cm_handle_connect(struct rdma_cm_id *cm_id,
Expand Down Expand Up @@ -321,7 +321,7 @@ void rds_iw_flush_mrs(void);
void rds_iw_remove_cm_id(struct rds_iw_device *rds_iwdev, struct rdma_cm_id *cm_id);

/* ib_recv.c */
int __init rds_iw_recv_init(void);
int rds_iw_recv_init(void);
void rds_iw_recv_exit(void);
int rds_iw_recv(struct rds_connection *conn);
int rds_iw_recv_refill(struct rds_connection *conn, gfp_t kptr_gfp,
Expand Down Expand Up @@ -370,7 +370,7 @@ unsigned int rds_iw_stats_info_copy(struct rds_info_iterator *iter,
unsigned int avail);

/* ib_sysctl.c */
int __init rds_iw_sysctl_init(void);
int rds_iw_sysctl_init(void);
void rds_iw_sysctl_exit(void);
extern unsigned long rds_iw_sysctl_max_send_wr;
extern unsigned long rds_iw_sysctl_max_recv_wr;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/iw_recv.c
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ int rds_iw_recv(struct rds_connection *conn)
return ret;
}

int __init rds_iw_recv_init(void)
int rds_iw_recv_init(void)
{
struct sysinfo si;
int ret = -ENOMEM;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/iw_sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ void rds_iw_sysctl_exit(void)
unregister_sysctl_table(rds_iw_sysctl_hdr);
}

int __init rds_iw_sysctl_init(void)
int rds_iw_sysctl_init(void)
{
rds_iw_sysctl_hdr = register_sysctl_paths(rds_iw_sysctl_path, rds_iw_sysctl_table);
if (!rds_iw_sysctl_hdr)
Expand Down
4 changes: 2 additions & 2 deletions net/rds/rdma_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id,
return ret;
}

static int __init rds_rdma_listen_init(void)
static int rds_rdma_listen_init(void)
{
struct sockaddr_in sin;
struct rdma_cm_id *cm_id;
Expand Down Expand Up @@ -177,7 +177,7 @@ static void rds_rdma_listen_stop(void)
}
}

int __init rds_rdma_init(void)
int rds_rdma_init(void)
{
int ret;

Expand Down
10 changes: 5 additions & 5 deletions net/rds/rds.h
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ void rds_cong_exit(void);
struct rds_message *rds_cong_update_alloc(struct rds_connection *conn);

/* conn.c */
int __init rds_conn_init(void);
int rds_conn_init(void);
void rds_conn_exit(void);
struct rds_connection *rds_conn_create(__be32 laddr, __be32 faddr,
struct rds_transport *trans, gfp_t gfp);
Expand Down Expand Up @@ -769,14 +769,14 @@ DECLARE_PER_CPU_SHARED_ALIGNED(struct rds_statistics, rds_stats);
put_cpu(); \
} while (0)
#define rds_stats_add(member, count) rds_stats_add_which(rds_stats, member, count)
int __init rds_stats_init(void);
int rds_stats_init(void);
void rds_stats_exit(void);
void rds_stats_info_copy(struct rds_info_iterator *iter,
uint64_t *values, const char *const *names,
size_t nr);

/* sysctl.c */
int __init rds_sysctl_init(void);
int rds_sysctl_init(void);
void rds_sysctl_exit(void);
extern unsigned long rds_sysctl_sndbuf_min;
extern unsigned long rds_sysctl_sndbuf_default;
Expand All @@ -790,7 +790,7 @@ extern unsigned long rds_sysctl_trace_flags;
extern unsigned int rds_sysctl_trace_level;

/* threads.c */
int __init rds_threads_init(void);
int rds_threads_init(void);
void rds_threads_exit(void);
extern struct workqueue_struct *rds_wq;
void rds_queue_reconnect(struct rds_connection *conn);
Expand All @@ -806,7 +806,7 @@ void rds_trans_unregister(struct rds_transport *trans);
struct rds_transport *rds_trans_get_preferred(__be32 addr);
unsigned int rds_trans_stats_info_copy(struct rds_info_iterator *iter,
unsigned int avail);
int __init rds_trans_init(void);
int rds_trans_init(void);
void rds_trans_exit(void);

#endif
2 changes: 1 addition & 1 deletion net/rds/stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ void rds_stats_exit(void)
rds_info_deregister_func(RDS_INFO_COUNTERS, rds_stats_info);
}

int __init rds_stats_init(void)
int rds_stats_init(void)
{
rds_info_register_func(RDS_INFO_COUNTERS, rds_stats_info);
return 0;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ void rds_sysctl_exit(void)
unregister_sysctl_table(rds_sysctl_reg_table);
}

int __init rds_sysctl_init(void)
int rds_sysctl_init(void)
{
rds_sysctl_reconnect_min = msecs_to_jiffies(1);
rds_sysctl_reconnect_min_jiffies = rds_sysctl_reconnect_min;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ struct rds_transport rds_tcp_transport = {
.t_prefer_loopback = 1,
};

int __init rds_tcp_init(void)
int rds_tcp_init(void)
{
int ret;

Expand Down
6 changes: 3 additions & 3 deletions net/rds/tcp.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct rds_tcp_statistics {
};

/* tcp.c */
int __init rds_tcp_init(void);
int rds_tcp_init(void);
void rds_tcp_exit(void);
void rds_tcp_tune(struct socket *sock);
void rds_tcp_nonagle(struct socket *sock);
Expand All @@ -61,12 +61,12 @@ void rds_tcp_conn_shutdown(struct rds_connection *conn);
void rds_tcp_state_change(struct sock *sk);

/* tcp_listen.c */
int __init rds_tcp_listen_init(void);
int rds_tcp_listen_init(void);
void rds_tcp_listen_stop(void);
void rds_tcp_listen_data_ready(struct sock *sk, int bytes);

/* tcp_recv.c */
int __init rds_tcp_recv_init(void);
int rds_tcp_recv_init(void);
void rds_tcp_recv_exit(void);
void rds_tcp_data_ready(struct sock *sk, int bytes);
int rds_tcp_recv(struct rds_connection *conn);
Expand Down
2 changes: 1 addition & 1 deletion net/rds/tcp_listen.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ void rds_tcp_listen_data_ready(struct sock *sk, int bytes)
ready(sk, bytes);
}

int __init rds_tcp_listen_init(void)
int rds_tcp_listen_init(void)
{
struct sockaddr_in sin;
struct socket *sock = NULL;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/tcp_recv.c
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ void rds_tcp_data_ready(struct sock *sk, int bytes)
ready(sk, bytes);
}

int __init rds_tcp_recv_init(void)
int rds_tcp_recv_init(void)
{
rds_tcp_incoming_slab = kmem_cache_create("rds_tcp_incoming",
sizeof(struct rds_tcp_incoming),
Expand Down
2 changes: 1 addition & 1 deletion net/rds/threads.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ void rds_threads_exit(void)
destroy_workqueue(rds_wq);
}

int __init rds_threads_init(void)
int rds_threads_init(void)
{
rds_wq = create_singlethread_workqueue("krdsd");
if (!rds_wq)
Expand Down

0 comments on commit ef87b7e

Please sign in to comment.