cfq-iosched: fix bad return value cfq_should_preempt()

Commit a6151c3 inadvertently reversed a preempt condition check, potentially causing a performance regression. Make the meta check correct again. Signed-off-by: Jens Axboe <[email protected]>
mrcsosa · Nov 3, 2009 · e6ec4fe · e6ec4fe
1 parent 8c4db33
commit e6ec4fe
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
@@ -2051,7 +2051,7 @@ cfq_should_preempt(struct cfq_data *cfqd, struct cfq_queue *new_cfqq,
 	 * it's a metadata request and the current queue is doing regular IO.
 	 */
 	if (rq_is_meta(rq) && !cfqq->meta_pending)
-		return false;
+		return true;
 
 	/*
 	 * Allow an RT request to pre-empt an ongoing non-RT cfqq timeslice.