Skip to content

Commit

Permalink
pidns: remove now unused find_pid function.
Browse files Browse the repository at this point in the history
This one had the only users so far - the kill_proc, which is removed, so
drop this (invalid in namespaced world) call too.

And of course - erase all references on it from comments.

Signed-off-by: Pavel Emelyanov <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
xemul authored and torvalds committed Jul 25, 2008
1 parent 19b0cfc commit e49859e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 11 deletions.
4 changes: 1 addition & 3 deletions include/linux/pid.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ enum pid_type
*/

struct upid {
/* Try to keep pid_chain in the same cacheline as nr for find_pid */
/* Try to keep pid_chain in the same cacheline as nr for find_vpid */
int nr;
struct pid_namespace *ns;
struct hlist_node pid_chain;
Expand Down Expand Up @@ -105,14 +105,12 @@ extern struct pid_namespace init_pid_ns;
* or rcu_read_lock() held.
*
* find_pid_ns() finds the pid in the namespace specified
* find_pid() find the pid by its global id, i.e. in the init namespace
* find_vpid() finr the pid by its virtual id, i.e. in the current namespace
*
* see also find_task_by_pid() set in include/linux/sched.h
*/
extern struct pid *find_pid_ns(int nr, struct pid_namespace *ns);
extern struct pid *find_vpid(int nr);
extern struct pid *find_pid(int nr);

/*
* Lookup a PID in the hash table, and return with it's count elevated.
Expand Down
2 changes: 1 addition & 1 deletion include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -1718,7 +1718,7 @@ extern struct pid_namespace init_pid_ns;
* find_task_by_pid():
* finds a task by its global pid
*
* see also find_pid() etc in include/linux/pid.h
* see also find_vpid() etc in include/linux/pid.h
*/

extern struct task_struct *find_task_by_pid_type_ns(int type, int pid,
Expand Down
8 changes: 1 addition & 7 deletions kernel/pid.c
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,6 @@ struct pid *find_vpid(int nr)
}
EXPORT_SYMBOL_GPL(find_vpid);

struct pid *find_pid(int nr)
{
return find_pid_ns(nr, &init_pid_ns);
}
EXPORT_SYMBOL_GPL(find_pid);

/*
* attach_pid() must be called with the tasklist_lock write-held.
*/
Expand Down Expand Up @@ -483,7 +477,7 @@ EXPORT_SYMBOL(task_session_nr_ns);
/*
* Used by proc to find the first pid that is greater then or equal to nr.
*
* If there is a pid at nr this function is exactly the same as find_pid.
* If there is a pid at nr this function is exactly the same as find_pid_ns.
*/
struct pid *find_ge_pid(int nr, struct pid_namespace *ns)
{
Expand Down

0 comments on commit e49859e

Please sign in to comment.