Skip to content

Commit

Permalink
[MTD] replace MTD_ROM with MTD_GENERIC_TYPE
Browse files Browse the repository at this point in the history
No mtd user should ever check for the device type.  Instead, device features
should be checked by the flags - if at all.
As a first step towards type removal, change MTD_ROM into MTD_GENERIC_TYPE.

Signed-off-by: Joern Engel <[email protected]>
  • Loading branch information
Joern Engel committed May 30, 2006
1 parent e121972 commit e369d62
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions drivers/mtd/chips/map_rom.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,13 @@ static struct mtd_info *map_rom_probe(struct map_info *map)
map->fldrv = &maprom_chipdrv;
mtd->priv = map;
mtd->name = map->name;
mtd->type = MTD_ROM;
mtd->type = MTD_GENERIC_TYPE;
mtd->size = map->size;
mtd->read = maprom_read;
mtd->write = maprom_write;
mtd->sync = maprom_nop;
mtd->flags = MTD_CAP_ROM;
mtd->erasesize = 131072;
while(mtd->size & (mtd->erasesize - 1))
mtd->erasesize >>= 1;
mtd->erasesize = map->size;

__module_get(THIS_MODULE);
return mtd;
Expand Down
2 changes: 1 addition & 1 deletion include/mtd/mtd-abi.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ struct mtd_oob_buf {

#define MTD_ABSENT 0
#define MTD_RAM 1
#define MTD_ROM 2
#define MTD_NORFLASH 3
#define MTD_NANDFLASH 4
#define MTD_DATAFLASH 6
#define MTD_GENERIC_TYPE 7

#define MTD_WRITEABLE 0x400 /* Device is writeable */
#define MTD_BIT_WRITEABLE 0x800 /* Single bits can be flipped */
Expand Down

0 comments on commit e369d62

Please sign in to comment.