Skip to content

Commit

Permalink
ipc: fix potential oops when src msg > 4k w/ MSG_COPY
Browse files Browse the repository at this point in the history
If the src msg is > 4k, then dest->next points to the
next allocated segment; resetting it just prior to dereferencing
is bad.

Signed-off-by: Peter Hurley <[email protected]>
Acked-by: Stanislav Kinsbursky <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
peterhurley authored and torvalds committed Mar 8, 2013
1 parent 47b3bc9 commit e1082f4
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ipc/msgutil.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ struct msg_msg *copy_msg(struct msg_msg *src, struct msg_msg *dst)
if (alen > DATALEN_MSG)
alen = DATALEN_MSG;

dst->next = NULL;
dst->security = NULL;

memcpy(dst + 1, src + 1, alen);

len -= alen;
Expand Down

0 comments on commit e1082f4

Please sign in to comment.