Skip to content

Commit

Permalink
Merge branch 'efi-core-for-linus' of git://git.kernel.org/pub/scm/lin…
Browse files Browse the repository at this point in the history
…ux/kernel/git/tip/tip

Pull EFI updates from Ingo Molnar:
 "The main changes in this cycle were:

   - Wire up the EFI RNG code for x86. This enables an additional source
     of entropy during early boot.

   - Enable the TPM event log code on ARM platforms.

   - Update Ard's email address"

* 'efi-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  efi: libstub/tpm: enable tpm eventlog function for ARM platforms
  x86: efi/random: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table
  efi/random: use arch-independent efi_call_proto()
  MAINTAINERS: update Ard's email address to @kernel.org
  • Loading branch information
torvalds committed Nov 26, 2019
2 parents 3f61281 + 2278f45 commit df28204
Show file tree
Hide file tree
Showing 8 changed files with 33 additions and 13 deletions.
1 change: 1 addition & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Andy Adamson <[email protected]>
Antoine Tenart <[email protected]>
Antonio Ospite <[email protected]> <[email protected]>
Archit Taneja <[email protected]>
Ard Biesheuvel <[email protected]> <[email protected]>
Arnaud Patard <[email protected]>
Arnd Bergmann <[email protected]>
Axel Dyks <[email protected]>
Expand Down
8 changes: 4 additions & 4 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -6019,14 +6019,14 @@ F: sound/usb/misc/ua101.c
EFI TEST DRIVER
L: [email protected]
M: Ivan Hu <[email protected]>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
M: Ard Biesheuvel <ardb@kernel.org>
S: Maintained
F: drivers/firmware/efi/test/

EFI VARIABLE FILESYSTEM
M: Matthew Garrett <[email protected]>
M: Jeremy Kerr <[email protected]>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
M: Ard Biesheuvel <ardb@kernel.org>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
L: [email protected]
S: Maintained
Expand Down Expand Up @@ -6207,7 +6207,7 @@ S: Supported
F: security/integrity/evm/

EXTENSIBLE FIRMWARE INTERFACE (EFI)
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
M: Ard Biesheuvel <ardb@kernel.org>
L: [email protected]
T: git git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
S: Maintained
Expand Down Expand Up @@ -15083,7 +15083,7 @@ F: include/media/soc_camera.h
F: drivers/staging/media/soc_camera/

SOCIONEXT SYNQUACER I2C DRIVER
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
M: Ard Biesheuvel <ardb@kernel.org>
L: [email protected]
S: Maintained
F: drivers/i2c/busses/i2c-synquacer.c
Expand Down
3 changes: 3 additions & 0 deletions arch/x86/boot/compressed/eboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,9 @@ efi_main(struct efi_config *c, struct boot_params *boot_params)

/* Ask the firmware to clear memory on unclean shutdown */
efi_enable_reset_attack_mitigation(sys_table);

efi_random_get_seed(sys_table);

efi_retrieve_tpm2_eventlog(sys_table);

setup_graphics(boot_params);
Expand Down
5 changes: 3 additions & 2 deletions drivers/firmware/efi/libstub/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ OBJECT_FILES_NON_STANDARD := y
# Prevents link failures: __sanitizer_cov_trace_pc() is not linked in.
KCOV_INSTRUMENT := n

lib-y := efi-stub-helper.o gop.o secureboot.o tpm.o
lib-y := efi-stub-helper.o gop.o secureboot.o tpm.o \
random.o

# include the stub's generic dependencies from lib/ when building for ARM/arm64
arm-deps-y := fdt_rw.c fdt_ro.c fdt_wip.c fdt.c fdt_empty_tree.c fdt_sw.c
Expand All @@ -47,7 +48,7 @@ arm-deps-$(CONFIG_ARM64) += sort.c
$(obj)/lib-%.o: $(srctree)/lib/%.c FORCE
$(call if_changed_rule,cc_o_c)

lib-$(CONFIG_EFI_ARMSTUB) += arm-stub.o fdt.o string.o random.o \
lib-$(CONFIG_EFI_ARMSTUB) += arm-stub.o fdt.o string.o \
$(patsubst %.c,lib-%.o,$(arm-deps-y))

lib-$(CONFIG_ARM) += arm32-stub.o
Expand Down
2 changes: 2 additions & 0 deletions drivers/firmware/efi/libstub/arm-stub.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ unsigned long efi_entry(void *handle, efi_system_table_t *sys_table,
goto fail_free_cmdline;
}

efi_retrieve_tpm2_eventlog(sys_table);

/* Ask the firmware to clear memory on unclean shutdown */
efi_enable_reset_attack_mitigation(sys_table);

Expand Down
2 changes: 0 additions & 2 deletions drivers/firmware/efi/libstub/efistub.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ efi_status_t efi_random_alloc(efi_system_table_t *sys_table_arg,

efi_status_t check_platform_features(efi_system_table_t *sys_table_arg);

efi_status_t efi_random_get_seed(efi_system_table_t *sys_table_arg);

void *get_efi_config_table(efi_system_table_t *sys_table, efi_guid_t guid);

/* Helper macros for the usual case of using simple C variables: */
Expand Down
23 changes: 18 additions & 5 deletions drivers/firmware/efi/libstub/random.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,18 @@

#include "efistub.h"

typedef struct efi_rng_protocol efi_rng_protocol_t;

typedef struct {
u32 get_info;
u32 get_rng;
} efi_rng_protocol_32_t;

typedef struct {
u64 get_info;
u64 get_rng;
} efi_rng_protocol_64_t;

struct efi_rng_protocol {
efi_status_t (*get_info)(struct efi_rng_protocol *,
unsigned long *, efi_guid_t *);
Expand All @@ -28,7 +40,7 @@ efi_status_t efi_get_random_bytes(efi_system_table_t *sys_table_arg,
if (status != EFI_SUCCESS)
return status;

return rng->get_rng(rng, NULL, size, out);
return efi_call_proto(efi_rng_protocol, get_rng, rng, NULL, size, out);
}

/*
Expand Down Expand Up @@ -161,15 +173,16 @@ efi_status_t efi_random_get_seed(efi_system_table_t *sys_table_arg)
if (status != EFI_SUCCESS)
return status;

status = rng->get_rng(rng, &rng_algo_raw, EFI_RANDOM_SEED_SIZE,
seed->bits);
status = efi_call_proto(efi_rng_protocol, get_rng, rng, &rng_algo_raw,
EFI_RANDOM_SEED_SIZE, seed->bits);

if (status == EFI_UNSUPPORTED)
/*
* Use whatever algorithm we have available if the raw algorithm
* is not implemented.
*/
status = rng->get_rng(rng, NULL, EFI_RANDOM_SEED_SIZE,
seed->bits);
status = efi_call_proto(efi_rng_protocol, get_rng, rng, NULL,
EFI_RANDOM_SEED_SIZE, seed->bits);

if (status != EFI_SUCCESS)
goto err_freepool;
Expand Down
2 changes: 2 additions & 0 deletions include/linux/efi.h
Original file line number Diff line number Diff line change
Expand Up @@ -1645,6 +1645,8 @@ static inline void
efi_enable_reset_attack_mitigation(efi_system_table_t *sys_table_arg) { }
#endif

efi_status_t efi_random_get_seed(efi_system_table_t *sys_table_arg);

void efi_retrieve_tpm2_eventlog(efi_system_table_t *sys_table);

/*
Expand Down

0 comments on commit df28204

Please sign in to comment.