Skip to content

Commit

Permalink
doc, net: Remove instruction to set net_device::trans_start
Browse files Browse the repository at this point in the history
Commit 08baf56 ('net:
txq_trans_update() helper') made it unnecessary for most drivers to
set net_device::trans_start (or netdev_queue::trans_start).

Signed-off-by: Ben Hutchings <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Ben Hutchings authored and davem330 committed Apr 6, 2012
1 parent b3cf654 commit de7aca1
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions Documentation/networking/driver.txt
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,10 @@ Transmit path guidelines:
TX_BUFFS_AVAIL(dp) > 0)
netif_wake_queue(dp->dev);

2) Do not forget to update netdev->trans_start to jiffies after
each new tx packet is given to the hardware.

3) An ndo_start_xmit method must not modify the shared parts of a
2) An ndo_start_xmit method must not modify the shared parts of a
cloned SKB.

4) Do not forget that once you return 0 from your ndo_start_xmit
3) Do not forget that once you return 0 from your ndo_start_xmit
method, it is your driver's responsibility to free up the SKB
and in some finite amount of time.

Expand Down

0 comments on commit de7aca1

Please sign in to comment.