Skip to content

Commit

Permalink
[XFRM]: Use kmemdup where appropriate
Browse files Browse the repository at this point in the history
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
Arnaldo Carvalho de Melo authored and David S. Miller committed Dec 3, 2006
1 parent 2710b57 commit cdbc6da
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions net/xfrm/xfrm_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,10 @@ static int attach_one_algo(struct xfrm_algo **algpp, u8 *props,
*props = algo->desc.sadb_alg_id;

len = sizeof(*ualg) + (ualg->alg_key_len + 7U) / 8;
p = kmalloc(len, GFP_KERNEL);
p = kmemdup(ualg, len, GFP_KERNEL);
if (!p)
return -ENOMEM;

memcpy(p, ualg, len);
strcpy(p->alg_name, algo->name);
*algpp = p;
return 0;
Expand All @@ -263,11 +262,10 @@ static int attach_encap_tmpl(struct xfrm_encap_tmpl **encapp, struct rtattr *u_a
return 0;

uencap = RTA_DATA(rta);
p = kmalloc(sizeof(*p), GFP_KERNEL);
p = kmemdup(uencap, sizeof(*p), GFP_KERNEL);
if (!p)
return -ENOMEM;

memcpy(p, uencap, sizeof(*p));
*encapp = p;
return 0;
}
Expand Down Expand Up @@ -305,11 +303,10 @@ static int attach_one_addr(xfrm_address_t **addrpp, struct rtattr *u_arg)
return 0;

uaddrp = RTA_DATA(rta);
p = kmalloc(sizeof(*p), GFP_KERNEL);
p = kmemdup(uaddrp, sizeof(*p), GFP_KERNEL);
if (!p)
return -ENOMEM;

memcpy(p, uaddrp, sizeof(*p));
*addrpp = p;
return 0;
}
Expand Down

0 comments on commit cdbc6da

Please sign in to comment.