Skip to content

Commit

Permalink
media: dvb-frontends/tda18271c2dd: fix handling of DVB-T parameters
Browse files Browse the repository at this point in the history
Add a break statement in set_params() for the SYS_DVBT(2).

As reported by gcc:

    drivers/media/dvb-frontends/tda18271c2dd.c:1144:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

There is a nested switch() inside the code with sets the tuner to
the right standard. Without the break, the code will always set to
DVB-C mode, with can be sub-optimal for DVB-T.

Signed-off-by: Daniel Scheller <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
herrnst authored and mchehab committed Jul 30, 2018
1 parent 875658a commit ca747d0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/media/dvb-frontends/tda18271c2dd.c
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,7 @@ static int set_params(struct dvb_frontend *fe)
default:
return -EINVAL;
}
break;
case SYS_DVBC_ANNEX_A:
case SYS_DVBC_ANNEX_C:
if (bw <= 6000000)
Expand Down

0 comments on commit ca747d0

Please sign in to comment.