Skip to content

Commit

Permalink
Merge tag 'hwmon-for-linus-v4.7-rc3' of git://git.kernel.org/pub/scm/…
Browse files Browse the repository at this point in the history
…linux/kernel/git/groeck/linux-staging

Pull hwmon fixes from Guenter Roeck:

 - fix regression in fam15h_power driver

 - minor variable type fix in lm90 driver

 - document compatible statement for ina2xx driver

* tag 'hwmon-for-linus-v4.7-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging:
  hwmon: (lm90) use proper type for update_interval
  hwmon: (ina2xx) Document compatible for INA231
  hwmon: (fam15h_power) Disable preemption when reading registers
  • Loading branch information
torvalds committed Jun 10, 2016
2 parents f5364c1 + 38bab98 commit c8f17d6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
1 change: 1 addition & 0 deletions Documentation/devicetree/bindings/hwmon/ina2xx.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Required properties:
- "ti,ina220" for ina220
- "ti,ina226" for ina226
- "ti,ina230" for ina230
- "ti,ina231" for ina231
- reg: I2C address

Optional properties:
Expand Down
8 changes: 2 additions & 6 deletions drivers/hwmon/fam15h_power.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ static void do_read_registers_on_cu(void *_data)
*/
static int read_registers(struct fam15h_power_data *data)
{
int this_cpu, ret, cpu;
int core, this_core;
cpumask_var_t mask;
int ret, cpu;

ret = zalloc_cpumask_var(&mask, GFP_KERNEL);
if (!ret)
Expand All @@ -183,7 +183,6 @@ static int read_registers(struct fam15h_power_data *data)
memset(data->cu_on, 0, sizeof(int) * MAX_CUS);

get_online_cpus();
this_cpu = smp_processor_id();

/*
* Choose the first online core of each compute unit, and then
Expand All @@ -205,12 +204,9 @@ static int read_registers(struct fam15h_power_data *data)
cpumask_set_cpu(cpumask_any(topology_sibling_cpumask(cpu)), mask);
}

if (cpumask_test_cpu(this_cpu, mask))
do_read_registers_on_cu(data);
on_each_cpu_mask(mask, do_read_registers_on_cu, data, true);

smp_call_function_many(mask, do_read_registers_on_cu, data, true);
put_online_cpus();

free_cpumask_var(mask);

return 0;
Expand Down
2 changes: 1 addition & 1 deletion drivers/hwmon/lm90.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ struct lm90_data {
int kind;
u32 flags;

int update_interval; /* in milliseconds */
unsigned int update_interval; /* in milliseconds */

u8 config_orig; /* Original configuration register value */
u8 convrate_orig; /* Original conversion rate register value */
Expand Down

0 comments on commit c8f17d6

Please sign in to comment.