Skip to content

Commit

Permalink
blk-mq-pci: add a fallback when pci_irq_get_affinity returns NULL
Browse files Browse the repository at this point in the history
While pci_irq_get_affinity should never fail for SMP kernel that
implement the affinity mapping, it will always return NULL in the
UP case, so provide a fallback mapping of all queues to CPU 0 in
that case.

Signed-off-by: Christoph Hellwig <[email protected]>
Cc: [email protected]
Reviewed-by: Omar Sandoval <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Christoph Hellwig authored and axboe committed Aug 18, 2017
1 parent 6caa050 commit c005390
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion block/blk-mq-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,18 @@ int blk_mq_pci_map_queues(struct blk_mq_tag_set *set, struct pci_dev *pdev)
for (queue = 0; queue < set->nr_hw_queues; queue++) {
mask = pci_irq_get_affinity(pdev, queue);
if (!mask)
return -EINVAL;
goto fallback;

for_each_cpu(cpu, mask)
set->mq_map[cpu] = queue;
}

return 0;

fallback:
WARN_ON_ONCE(set->nr_hw_queues > 1);
for_each_possible_cpu(cpu)
set->mq_map[cpu] = 0;
return 0;
}
EXPORT_SYMBOL_GPL(blk_mq_pci_map_queues);

0 comments on commit c005390

Please sign in to comment.